[PATCH] D55681: [llvm] API for encoding/decoding DWARF discriminators.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 19 11:23:40 PST 2018
dblaikie added a comment.
Might be worth having a summary of the goals here (rather than only by reference to the design discussion thread) for review and later as commit history, etc.
================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1605-1606
+ /// value.
+ static unsigned encodeDiscriminator(unsigned BD, unsigned DF, unsigned CI,
+ bool &Success);
+
----------------
Would Expected<unsigned> or Optional<unsigned> be more suitable here rather than using a bool as an out parameter to report errors?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55681/new/
https://reviews.llvm.org/D55681
More information about the llvm-commits
mailing list