[PATCH] D55596: Reimplement Thread Static Data ASan routines with TLS
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 19 02:49:11 PST 2018
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
should this cause any changes in tests? maybe something is going to pass now?
================
Comment at: lib/asan/asan_posix.cc:49
+static bool tsd_key_inited = false;
+static void (*tsd_destructor)(void *tsd) = nullptr;
+
----------------
krytarowski wrote:
> vitalybuka wrote:
> > tsd_key_inited is redundant here?
> It serves just as an additional assert, I can drop it.
I'd prefer if you drop, for simplicity.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55596/new/
https://reviews.llvm.org/D55596
More information about the llvm-commits
mailing list