[PATCH] D54939: [llvm-objcopy] Initial COFF support

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 23:20:52 PST 2018


mstorsjo marked 3 inline comments as done.
mstorsjo added inline comments.


================
Comment at: tools/llvm-objcopy/COFF/Writer.cpp:18
+#include "llvm/Support/ErrorHandling.h"
+#include "llvm/Support/FileOutputBuffer.h"
+#include <cstddef>
----------------
jakehehrlich wrote:
> Why do you need this?
On a second look, I don't - I had somehow conflated it with the header for the llvm-objcopy specific `Buffer` class. Will remove before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54939/new/

https://reviews.llvm.org/D54939





More information about the llvm-commits mailing list