[LNT] r349582 - Some type annotations to make Mypy happier

[Chris Matthews via llvm-commits]

Author: cmatthews
Date: Tue Dec 18 15:55:14 2018
New Revision: 349582

URL: http://llvm.org/viewvc/llvm-project?rev=349582&view=rev
Log:
Some type annotations to make Mypy happier

Modified:
    lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py
    lnt/trunk/lnt/server/db/rules_manager.py

Modified: lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py?rev=349582&r1=349581&r2=349582&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py (original)
+++ lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py Tue Dec 18 15:55:14 2018
@@ -3,6 +3,7 @@ Detcted + fixed -> Ignored
 Staged or Active + fixed -> Verify
 """
 from sqlalchemy.orm.session import Session
+from typing import Dict
 
 from lnt.server.db.regression import RegressionState
 from lnt.server.db.regression import get_cr_for_field_change, get_ris
@@ -11,6 +12,7 @@ from lnt.testing.util.commands import ti
 from lnt.util import logger
 from lnt.server.reporting.analysis import MIN_PERCENTAGE_CHANGE
 
+
 def _fixed_rind(session, ts, rind):
     """Is this regression indicator fixed?"""
     fc = rind.field_change
@@ -33,7 +35,7 @@ def is_fixed(session, ts, regression):
 
 
 def impacts(session, ts, run_id, regression):
-    # type: (Session, TestSuiteDB, int, object) -> bool
+    # type: (Session, TestSuiteDB, int, TestSuiteDB.Regression) -> bool
     """Does this run have a chance of impacting this regression?
 
     This is just to prevent doing a full comparison, so we don't have
@@ -67,7 +69,7 @@ def age_out_oldest_regressions(session,
         .join(ts.FieldChange) \
         .all()
 
-    regression_newest_change = {}
+    regression_newest_change = {}  # type: Dict[int, int]
     for regression_id, order_id in regression_orders:
         current = regression_newest_change.get(regression_id)
         if current is None or current < order_id:

Modified: lnt/trunk/lnt/server/db/rules_manager.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/rules_manager.py?rev=349582&r1=349581&r2=349582&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/rules_manager.py (original)
+++ lnt/trunk/lnt/server/db/rules_manager.py Tue Dec 18 15:55:14 2018
@@ -3,6 +3,9 @@ Define facilities for automatically appl
 """
 import os
 import re
+
+from typing import Callable, Dict, List
+
 from lnt.util import logger
 
 
@@ -50,7 +53,8 @@ HOOKS = {
     'post_submission_hook': [],
     'post_regression_create_hook': [],
     'is_useful_change': [],
-}
+}  # type: Dict['str', List[Callable]]
+
 DESCRIPTIONS = {}
 HOOKS_LOADED = False