[PATCH] D54153: Fix compilation issue in VS2017 with Clang-tablegen and LLVM-tablegen

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 14:44:49 PST 2018


aganea reopened this revision.
aganea added a comment.
This revision is now accepted and ready to land.

I'm reopening this because there was an issue <http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/14705/steps/cmake-configure/logs/stdio> after committing, in the case when `clang` is inside `llvm/tools/`.
I've added `AND TARGET ${project}-tablegen-host` below, however this seems to hide a bigger issue, and I wanted you to be aware of it.
It seems that Clang's cmake files are executed in that case (when `clang` is checkedout in `llvm/tools/clang`), even though I didn't tell cmake that I wanted to build clang. I'm not sure that is the expected behavior, I'll let you judge.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54153/new/

https://reviews.llvm.org/D54153





More information about the llvm-commits mailing list