[PATCH] D53736: [BTF] Add BTF DebugInfo

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 14:36:59 PST 2018


This is really great. I've gotten the review in the next patches.

Thanks!

On Sun, Dec 16, 2018 at 9:56 PM Yonghong Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> yonghong-song added a comment.
>
> @echristo @aprantl @dblaikie This patch has stuck in this state for more
> than one month and did not make progress.
> I have suggested a possible way to move some header files to include
> directory and then we will be
> able to move BTFDebug.{cpp,h} under BPF directory. I have implemented this
> approach with the
> following three patches for easy to see pro and cons of two approaches:
>
>   (1) https://reviews.llvm.org/D55755, moving header files
>   (2) https://reviews.llvm.org/D55756, changes some fields from private
> to protected
>   (3) https://reviews.llvm.org/D55752, changes only under target BPF
>
> The new patch series tried to minimize the changes outside the BPF target.
> I will really appreciate if you can timely review this patch and related
> other "competing" patches.
> Thanks!
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D53736/new/
>
> https://reviews.llvm.org/D53736
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181218/8d24589f/attachment.html>


More information about the llvm-commits mailing list