[PATCH] D55729: [CodeGenPrepare] Fix bad IR created by large offset GEP splitting.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 13:37:58 PST 2018


spatel accepted this revision.
spatel added a comment.

I've never looked at that chunk of CGP before, but the code change looks strictly safer, so LGTM too. 
It would be nicer if that test file had an 'opt -codegenprepare' RUN with complete IR output, so we could see exactly what's happening there to the IR, but that could be a follow-up patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55729/new/

https://reviews.llvm.org/D55729





More information about the llvm-commits mailing list