[PATCH] D55845: Reject .so files if -static is given.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/ELF/static-error.s:7
+// RUN: ld.lld -o /dev/null %t.o %t.so
+// RUN: not ld.lld -o /dev/null -static %t.o %t.so >& %t.log
+// RUN: FileCheck %s < %t.log
----------------
ruiu wrote:
> MaskRay wrote:
> > POSIX sh does not support `>&` (but supports `>&fd`)
> > 
> > You may use `2>&1 >/dev/null | FileCheck` if you want to emphasize stderr is checked.
> Even thought lit tests support features such as redirection that you can find in Unix shells, these RUN commands are not run on a Unix shell, so it is safe to use >& as long as it works on lit.
`2>&1 | FileCheck` LG.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55845/new/

https://reviews.llvm.org/D55845