[PATCH] D54892: [LAA] Introduce enum for vectorization safety status (NFC).
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 18 12:35:49 PST 2018
fhahn added inline comments.
================
Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:221
+ return ShouldRetryWithRuntimeCheck &&
+ Status == VectorizationSafetyStatus::Unsafe;
+ }
----------------
Ayal wrote:
> This is redundant, as `ShouldRetryWithRuntimeCheck` implies Unsafe. I.e., can assert !(Should && Safe).
> When SafeWithRtChecks is added, in next patch, consider renaming the flag or method (slightly), as they will no longer mean exactly the same thing.
Yep, I dropped all changes to this function from this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54892/new/
https://reviews.llvm.org/D54892
More information about the llvm-commits
mailing list