[PATCH] D54153: Fix compilation issue in VS2017 with Clang-tablegen and LLVM-tablegen
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 18 11:09:47 PST 2018
aganea added a comment.
In D54153#1291830 <https://reviews.llvm.org/D54153#1291830>, @beanz wrote:
> I’m very confused how this could happen with Ninja. All the CMake invocations are done in targets with ‘USES_TERMINAL’ set on them which puts them in the ‘console’ pool which only allows one task at a time. So there shouldn’t be a way to have more than one Ninja invocation running at a time.
I wasn't able to reproduce the issue with Ninja. This might be linked to the AV software.
To all: can I go ahead with the patch? This fixes the Visual Studio builds at least.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54153/new/
https://reviews.llvm.org/D54153
More information about the llvm-commits
mailing list