[PATCH] D55800: [ELF] Place .note in the first page to ensure they are available in core files

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Writer.cpp:773-777
+  // We create a NOTE segment for contiguous .note sections, so make them
+  // contigous if there are more than one .note section with the same
+  // attributes. They contain information important in core files (e.g.
+  // .note.gnu.build-id identifies the origin of the core, .note.tag stores
+  // NT_FREEBSD_ABI_TAG). Ensure they are in the first page.
----------------
This exiting comment is a bit pointless. Let's update:

  Put .note sections at the beginning of an output file so that they are likely to be included in a core file even if core file size is limited by ulimit. In particular, we want a .note.gnu.build-id and a .note.tag to be included in a core to match core files with executable files.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55800/new/

https://reviews.llvm.org/D55800