[PATCH] D55842: Let TableGen write output only if it changed, instead of doing so in cmake, attempt 2

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: dberris.
Herald added a subscriber: mgorny.

Removes one subprocess and one temp file from the build for each tablegen invocation.

This attempts to reland r330742. r330742 got reverted because some people reported that llvm-tblgen ran on every build after it.

This could happen if the depfile output got deleted without deleting the main .inc output. To fix, make TableGen always write the depfile, but keep writing the main .inc output only if it has changed. This matches what we did in cmake before.

dberris, could you check if things are better for you with this version?


https://reviews.llvm.org/D55842

Files:
  cmake/modules/TableGen.cmake
  lib/TableGen/Main.cpp
  utils/gn/secondary/llvm/utils/TableGen/tablegen.gni

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55842.178736.patch
Type: text/x-patch
Size: 4822 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181218/a5f1053a/attachment.bin>