[PATCH] D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing

Tue Dec 18 09:32:00 PST 2018

probinson added a comment.

In D55281#1334789 <https://reviews.llvm.org/D55281#1334789>, @dblaikie wrote:

> In D55281#1334783 <https://reviews.llvm.org/D55281#1334783>, @probinson wrote:
>
> > In D55281#1334706 <https://reviews.llvm.org/D55281#1334706>, @dblaikie wrote:
> >
> > > I'm just still not sure the extra cl::opt is worth it, though - are you? Is the extra coverage significant/important?
> >
> >
> > I'd rather see a test break locally (because it's target-agnostic and uses the flag) than wait for some NVPTX-target bot to break after I commit.
>
>
> Do you trim the target set you build/dev with locally? Does that save much time - I build with the default, all the (non-experimental) targets enabled, so NVPTX failures do happen locally.

It saves some.   I'm building on a 6-core Windows box so not a huge level of parallelism--one of the prices of working remotely.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55281/new/

https://reviews.llvm.org/D55281