[PATCH] D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing

Tue Dec 18 09:22:28 PST 2018

probinson added a comment.

In D55281#1334706 <https://reviews.llvm.org/D55281#1334706>, @dblaikie wrote:

> I'm just still not sure the extra cl::opt is worth it, though - are you? Is the extra coverage significant/important?

I'd rather see a test break locally (because it's target-agnostic and uses the flag) than wait for some NVPTX-target bot to break after I commit.

> I think the only reason we have a flag for the debugger tuning is that it can't always be deduced from the triple (eg: folks using LLDB on Linux, etc) - but this case can, it's always NVPTX, there's nothing else currently possible to do with that target other than emit assembly that goes to ptxas.
>  But yeah, as a developer/testing-only feature I don't object too much to a use-ptxas-format flag to cover all this, but I still think it opens up a "wait, is there some other way/reason to be using ptxas other than for the NVPTX target?".

I'd hope that a "use-ptxas-format" cl::opt would have commentary to answer that exact question.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55281/new/

https://reviews.llvm.org/D55281