[PATCH] D55821: [llvm-objdump] - Demangle the symbols when printing symbol table and relocations.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 07:08:02 PST 2018


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Can you confirm is the following case is covered by this change? Inline listing of relocations when dumping disassembly (i.e. -d -r) also print the symbol name.

LGTM, if it does.



================
Comment at: test/tools/llvm-objdump/X86/demangle.s:4
+
+## Check we demangle symbols when print relocations.
+# CHECK:      000000000000001 R_X86_64_PLT32 foo()-4
----------------
print -> printing


================
Comment at: test/tools/llvm-objdump/X86/demangle.s:7
+
+## Check we demangle symbols when print symbol table.
+# CHECK:      SYMBOL TABLE:
----------------
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55821/new/

https://reviews.llvm.org/D55821





More information about the llvm-commits mailing list