[PATCH] D55822: [SelectionDAG] Optional handling of UNDEF elements in matchBinaryPredicate

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 06:51:13 PST 2018


andreadb added a comment.

As I wrote to D55819 <https://reviews.llvm.org/D55819>, I think this is a nice improvement and makes the matching logic resilient to the presence of undefs in the input vectors. It also fixes the regression introduced by D55600 <https://reviews.llvm.org/D55600> in @knownbits_mask_or_shuffle_uitofp. So, overall, I think this is a nice improvement.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55822/new/

https://reviews.llvm.org/D55822





More information about the llvm-commits mailing list