[PATCH] D55743: [gn build] Add build files for llvm-ar, llvm-nm, llvm-objdump, llvm-readelf (and deps DebugInfo/Symbolize, ToolDrivers/dll-tool)

[Nico Weber via Phabricator via llvm-commits]

thakis marked 2 inline comments as done.
thakis added a comment.

Thanks! Landing with comment addressed.



================
Comment at: llvm/utils/gn/secondary/llvm/tools/llvm-ar/BUILD.gn:8
+]
+foreach(target, symlinks) {
+  symlink_or_copy(target) {
----------------
phosek wrote:
> Shouldn't this also symlink `llvm-ar` as `ar` if `llvm_install_binutils_symlinks` is set?
It should, thanks for catching this!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55743/new/

https://reviews.llvm.org/D55743