[PATCH] D55817: [ELF][ARM] Process ARM build attributes of dynamic libraries.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputFiles.cpp:591
+  ArrayRef<uint8_t> Contents = check(F->getObj().getSectionContents(&Sec));
+  Attributes.Parse(Contents, /*isLittle*/ Config->EKind == ELF32LEKind);
+  updateSupportedARMFeatures(Attributes);
----------------
We have `Config->IsLE`.


================
Comment at: ELF/InputFiles.cpp:1005
 template <class ELFT> void SharedFile<ELFT>::parseRest() {
+  if (this->ARMAttributesSec && Config->EMachine == EM_ARM)
+    processARMAttributesSection(this, *(this->ARMAttributesSec));
----------------
Can we have `ARMAttributesSec` when Config->EMachine != EM_ARM?
Seems it can be just `if (this->ARMAttributesSec)`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55817/new/

https://reviews.llvm.org/D55817