[PATCH] D55348: Change the objc ARC optimizer to use the new objc.* intrinsics

[Pete Cooper via Phabricator via llvm-commits]

pete marked 6 inline comments as done.
pete added inline comments.


================
Comment at: lib/Transforms/ObjCARC/ARCRuntimeEntryPoints.h:92
+      return getIntrinsicEntryPoint(RetainRV,
+                                Intrinsic::objc_retainAutoreleasedReturnValue);
     case ARCRuntimeEntryPointKind::RetainAutorelease:
----------------
ahatanak wrote:
> Indentation looks incorrect.
Ah yeah, 80 cols so had to do it this way :(


================
Comment at: lib/Transforms/ObjCARC/ARCRuntimeEntryPoints.h:98
+      return getIntrinsicEntryPoint(RetainAutoreleaseRV,
+                                Intrinsic::objc_retainAutoreleaseReturnValue);
     }
----------------
ahatanak wrote:
> Indentation looks incorrect.
Also 80 cols.


================
Comment at: test/Transforms/ObjCARC/allocas.ll:12
 
 declare i8* @objc_retainedObject(i8*)
 declare i8* @objc_unretainedObject(i8*)
----------------
ahatanak wrote:
> Is there a reason we don't use @llvm.objc.retainedObject here and in test/Transforms/ObjCARC/rv.ll?
Good catch!

Looks like those are declared but unused in both tests.  I'll remove them in a followup.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55348/new/

https://reviews.llvm.org/D55348