[PATCH] D55797: [WebAssembly] Make assembler check for proper nesting of control flow.

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 17 17:28:05 PST 2018


aheejin added a comment.

Nevermind these two comments, but still think a error-generating test case would be great



================
Comment at: test/MC/WebAssembly/basic-assembly.s:66
+    #else
+    #end_if
     f32x4.add
----------------
aheejin wrote:
> I guess this is not relevant to this CL?
Oh nevermind, it is.


================
Comment at: test/MC/WebAssembly/basic-assembly.s:141
+# DONT-CHECK-NEXT:      else
+# DONT-CHECK-NEXT:      end_if
 # CHECK-NEXT:      f32x4.add
----------------
aheejin wrote:
> Here too
Nevermind again


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55797/new/

https://reviews.llvm.org/D55797





More information about the llvm-commits mailing list