[PATCH] D55293: [LLD][COFF] Unmerged sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Is `.CRT$XCU` just an example, or do you want to do something special for `.CRT$XCU`? If latter is the case, have you considered just directly implementing what you want do?



================
Comment at: COFF/Writer.h:82
 
+  std::vector<UnmergedSection *> ContribSections;
+
----------------
ruiu wrote:
> mstorsjo wrote:
> > Maybe leave out the `ContribSections` part from this patch - as far as I see it's not actually needed/used at this stage yet, and introducing it here makes the patch a bit more confusing.
> I don't think I understand the point of this change. Should the fact that some section is not assigned to some output section be a C++ class? It seems to me that that's a bit weird concept to be a class. Also, OutputSection has a list of unmerged sections, which seems odd to me too because once they are added, they are no longer unmerged.
> 
> I guess that first of all, I don't understand the intention of this change. Are you changing the code so that you can handle sections in input files and synthetic sections in the same way?
It seems you are not using this member.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55293/new/

https://reviews.llvm.org/D55293