[PATCH] D55747: [SelectionDAGBuilder] Enable funnel shift building to custom rotates

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/funnel-shift-rot.ll:94-96
 ; Vector rotate.
 
 define <4 x i32> @rotl_v4i32(<4 x i32> %x, <4 x i32> %z) nounwind {
----------------
spatel wrote:
> Is it worth repeating some of the code comments here to describe how this works? 
> Shouldn't we have coverage for v8i16 and 256/512-bit custom types?
What do you think is the best way forward for vector test coverage? We already have the vector-rotate-*.ll tests (which are raw shl+lshr+or patterns) - should those be replaced with fshl/fshr "rotate" intrinsics?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55747/new/

https://reviews.llvm.org/D55747