[PATCH] D55554: [HWASAN/rt] Implement support for memory intrinsics

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 17 12:43:54 PST 2018


eugenis added inline comments.


================
Comment at: lib/hwasan/hwasan_memintrinsics.cc:29
+  uptr addr = reinterpret_cast<uptr>(p);
+  if (flags()->halt_on_error)
+    CheckAddressSized<ErrorAction::Abort, AT>(addr, size);
----------------
You don't need this - see HwasanOnSIGTRAP, always using ErrorAction::Recover should have  the desired behavior.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55554/new/

https://reviews.llvm.org/D55554





More information about the llvm-commits mailing list