[PATCH] D55681: [llvm] API for encoding/decoding DWARF discriminators.

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

LGTM from my limited knowledge on discriminator. I added dblaikie to help on the review.



================
Comment at: lib/IR/DebugInfoMetadata.cpp:140-141
+
+  // Alternatively, we could determine Success during encoding, but the alternative
+  // here is simpler to understand.
+  unsigned TBD, TDF, TCI = 0;
----------------
Maybe make the comment more explicitly that encode may fail due to overflow of certain component. Currently the overflow failure is detected by checking the equivalence of all the components before encoding and after decoding.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55681/new/

https://reviews.llvm.org/D55681