[PATCH] D54653: Remove branch from CreateAlignmentAssumption
James Y Knight via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 17 10:51:44 PST 2018
jyknight added a comment.
In D54653#1320357 <https://reviews.llvm.org/D54653#1320357>, @jyknight wrote:
> > Thus, I think that the simple expression will still work even with this use case.
>
> Indeed so!
>
> I think the rule can be more clearly stated as: When the pointer is non-null, then the alignment must be a positive power of 2 (otherwise UB). An ubsan checker will need to take that into account as well.
(BTW, in case it wasn't clear here -- I no longer object to Hal's suggestion.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54653/new/
https://reviews.llvm.org/D54653
More information about the llvm-commits
mailing list