[PATCH] D55108: [AArch64] Re-run load/store optimizer after aggressive tail duplication

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 17 02:48:50 PST 2018


labrinea marked 2 inline comments as done.
labrinea added a comment.

In D55108#1330014 <https://reviews.llvm.org/D55108#1330014>, @dmgreen wrote:

> IIRC, there is a test for the pass pipeline I would expect needs updating.


Indeed that is `test/CodeGen/AArch64/O3-pipeline.ll`. Fixed now.



================
Comment at: test/CodeGen/AArch64/ldst-opt-after-block-placement.ll:31
   %1 = load i64, i64* %0, align 8
   %2 = getelementptr inbounds i64, i64* %ptr, i64 3
   store i64 0, i64* %0, align 8
----------------
dmgreen wrote:
> %2 is never used here.
Good catch. Removed now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55108/new/

https://reviews.llvm.org/D55108





More information about the llvm-commits mailing list