[PATCH] D55711: Don't trigger sanitizer initialization from `sysctlbyname` interceptor.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 16 14:43:25 PST 2018


delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7542
   void *ctx;
+  if (COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED) {
+    return internal_sysctl(name, namelen, oldp, oldlenp, newp, newlen);
----------------
krytarowski wrote:
> Drop brackets.
Do you mean the curly braces (`{ ...}`)? Dropping the brackets around `COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED` doesn't make much sense.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55711/new/

https://reviews.llvm.org/D55711





More information about the llvm-commits mailing list