[PATCH] D55711: Don't trigger sanitizer initialization from `sysctlbyname` interceptor.

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 16 13:48:52 PST 2018


krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7542
   void *ctx;
   COMMON_INTERCEPTOR_ENTER(ctx, sysctl, name, namelen, oldp, oldlenp, newp,
                            newlen);
----------------
delcypher wrote:
> vitalybuka wrote:
> > Could you please update all 3
> > 
> @vitalybuka How can we do `sysctlnametomib`? There's no `internal_sysctlnametomib` for me to use.
For simplicity I would skip it now unless there will be a real problem detected.

If we need it, it can be likely reimplemented with internal_sysctl()... but the reimplementation would likely be complex.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55711/new/

https://reviews.llvm.org/D55711





More information about the llvm-commits mailing list