[PATCH] D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 16 03:44:23 PST 2018


delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: test/sanitizer_common/CMakeLists.txt:14
+  if (COMPILER_RT_HAS_${SANITIZER_TOOL_UPPER})
+    list(APPEND SUPPORTED_TOOLS ${SANITIZER_TOOL})
+  endif()
----------------
Should we guard against ANDROID and WINDOWS here? We weren't running on those platforms previously and it's likely that this change would cause the tests to be run for those platforms.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55740/new/

https://reviews.llvm.org/D55740





More information about the llvm-commits mailing list