[PATCH] D55694: GlobalISel: Improve crash on invalid mapping

[Justin Bogner via Phabricator via llvm-commits]

bogner added a comment.

I don’t think I understand what this is trying to accomplish. ISTM that this will now hit a null dereference on line 123 when we read BreadDown in the case that NumBreakDowns is zero, but this is to avoid hitting an assert somewhere else? If this is to make it clearer as to what’s failing, shouldn’t we assert NumBreakDowns != 0 here instead of just hoping to crash on a null dereference?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55694/new/

https://reviews.llvm.org/D55694