[PATCH] D52999: [FileCheck] Annotate input dump (1/7)
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 15 05:54:32 PST 2018
jdenny marked 2 inline comments as done.
jdenny added inline comments.
================
Comment at: llvm/include/llvm/Support/FileCheck.h:167
+ /// The search range.
+ unsigned InputStartLine, InputStartCol, InputEndLine, InputEndCol;
+ FileCheckDiag(const SourceMgr &SM, const Check::FileCheckType &CheckTy,
----------------
jdenny wrote:
> probinson wrote:
> > The style guide doesn't actually say this, but it's pretty much universal in the code base to declare each member separately.
> Ah, I missed that. I'll get it before committing.
Done in D55738.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52999/new/
https://reviews.llvm.org/D52999
More information about the llvm-commits
mailing list