[PATCH] D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path.

[Satish K Guggilla via Phabricator via llvm-commits]

sguggill added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlanPredicator.cpp:46
+  VPValue *IntermediateVal = nullptr;
+  if (ET == EdgeType::TRUE_EDGE)
+    // CurrBB is the true successor of PredBB - nothing to do here.
----------------
fhahn wrote:
> If we EdgeType only has TRUE_EDGE and FALSE_EDGE and we turn this into a switch, we will get a nice compiler warning about missing cases if we add more elements to EdgeType.
I have modified EdgeType to only contain TRUE_EDGE and FALSE_EDGE. However, in the switch I went with a default case where we call llvm_unreachable to get a compiler runtime error if we see an edgetype that is not handled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53349/new/

https://reviews.llvm.org/D53349