[PATCH] D55689: [llvm-xray] Store offset pointers in temporaries

[Stephane Moore via Phabricator via llvm-commits]

stephanemoore added inline comments.


================
Comment at: llvm/trunk/lib/XRay/InstrumentationMap.cpp:141
+    uint32_t AddrPtr = OffsetPtr;
+    Entry.Address = RelocateOrElse(AddrOff, Extractor.getU64(&OffsetPtr));
+    uint32_t FuncPtr = OffsetPtr;
----------------
Did you mean `AddrPtr` rather than `AddrOff`?


================
Comment at: llvm/trunk/lib/XRay/InstrumentationMap.cpp:143
+    uint32_t FuncPtr = OffsetPtr;
+    Entry.Function = RelocateOrElse(FuncOff, Extractor.getU64(&OffsetPtr));
     auto Kind = Extractor.getU8(&OffsetPtr);
----------------
Did you mean `FuncPtr` rather than `FuncOff`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55689/new/

https://reviews.llvm.org/D55689