[PATCH] D53898: [FileCheck] Annotate input dump (6/7)

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/test/FileCheck/dump-input-annotations.txt:322
 ; RUN: not FileCheck -dump-input=always -input-file %t.in %t.chk -v 2>&1 \
-; RUN: | FileCheck -match-full-lines %s -check-prefixes=DAG,DAG-V
+; RUN: | FileCheck -match-full-lines %s -check-prefixes=DAG,DAG-V,DAG-VQ
 ; RUN: not FileCheck -dump-input=always -input-file %t.in %t.chk -vv 2>&1 \
----------------
jdenny wrote:
> probinson wrote:
> > I guess VQ means "-v but not -vv" here?
> Yep, I meant Q for quiet.  I'm happy to rename or add comments to explain if you think that would be helpful.
You have a mix of 5 directive names in the same sequence of checks, I think a bit of commentary would do no harm, :-)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53898/new/

https://reviews.llvm.org/D53898