[PATCH] D53899: [FileCheck] Annotate input dump (7/7)

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/dump-input-annotations.txt:93
 ; CNT-Q-NEXT:   count:1       X~~~~~ error: no match found
 ; CNT-V-NEXT:   count:1'2     X~~~~~ error: no match found
 ; CNT-NEXT:     >>>>>>
----------------
>>! In D53899#1331576, @probinson wrote:
>>>! In D53899#1328955, @jdenny wrote:
>> Remove MatchTypeCount, which is unused as of this patch.

To be clear, I originally meant MatchTypeCount to be a count of the MatchType members, so it's not actually related to your question below.  In this version of the patch series, that wasn't even it's role anymore.  I should have named it something more like MatchTypeUndefined.  Sorry about that.  Anyway, this final patch removes it.
 
> What do we see if a Counted match doesn't have enough matches?  I'm not seeing a test that covers that case.

I'm responding as an inline comment in the test that covers it.  (Don't be misled: the error isn't reported twice as CNT-Q and CNT-V are not active at the same time.)

Do you feel we need a separate MatchType and a more specific note for this case?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53899/new/

https://reviews.llvm.org/D53899