[PATCH] D55682: [ELF] Support defining __start/__stop symbols as hidden

[Joerg Sonnenberger via llvm-commits]

On Thu, Dec 13, 2018 at 11:40:24PM +0000, Petr Hosek via Phabricator via llvm-commits wrote:
> phosek created this revision.
> phosek added a reviewer: ruiu.
> Herald added subscribers: llvm-commits, arichardson, emaste.
> Herald added a reviewer: espindola.
> 
> We cannot define these symbols as hidden by default because some
> users apparently rely on using dlsym to look them up, see
> https://sourceware.org/bugzilla/show_bug.cgi?id=21964

I don't find that bug report to be very convincing and it screams bad
design to me. IMO if you expect __start_* or __stop_* to be emitted in
the public symbol table, you should have a declaration for them.

Joerg