[PATCH] D55554: [HWASAN/rt] Implement support for memory intrinsics

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/hwasan/hwasan.cc:532
+void *__hwasan_memset(void *block, int c, uptr size) {
+  CheckAddressSized<ErrorAction::Abort, AccessType::Store>(
+      reinterpret_cast<uptr>(block), size);
----------------
evgeny777 wrote:
> eugenis wrote:
> > eugenis wrote:
> > > This way -fsanitize-recover does not apply to mem intrinsics. I think, for consistency, there needs to be a __hwasan_memset_noabort variant, used in instrumentation when !Recover.
> > please also address this comment
> I noticed that ASAN doesn't have noabort versions, instead mem intrinsic behavior is controlled by `halt_on_error` flag in runtme. How about doing the same here?
OK, sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55554/new/

https://reviews.llvm.org/D55554