[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds
Arnaud Bienner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 14 07:21:25 PST 2018
ArnaudBienner added a comment.
Really sorry about breaking the build :( Thanks for reverting it.
Actually, I think we could fix that test by removing the " +1": AFAICT this test is checking that warnings are correctly emitted from clang, but not testing all the warnings. So the conversion from const char* to int is enough: no need to have an extra +1 at the end.
I will update my patch to update the test accordingly.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55382/new/
https://reviews.llvm.org/D55382
More information about the llvm-commits
mailing list