[PATCH] D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/CodeGen/ExpandMemCmp.cpp:166
+  // is larger than the max allowed.
+  if ((NumNonOverlappingLoads + !!(Size > 0)) > MaxNumLoads)
+    return {};
----------------
I'm still not clear on this: if Size is 0, does that imply that computeGreedy failed?


================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:2902
     Options.LoadSizes.push_back(1);
+    // All GPR loads can be unaligned, and vector loads too starting form SSE2.
+    Options.AllowOverlappingLoads = true;
----------------
form -> from (as suggested previously)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55263/new/

https://reviews.llvm.org/D55263