[PATCH] D54743: SROA: preserve alignment tags on loads and stores.

[Tim Northover via Phabricator via llvm-commits]

t.p.northover marked an inline comment as done.
t.p.northover added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:3294
+                   AAMDNodes AATags, unsigned BaseAlign, const DataLayout &DL)
+        : OpSplitter<LoadOpSplitter>(InsertionPoint, Ptr, BaseTy, AATags,
+                                     BaseAlign, DL) {}
----------------
Gerolf wrote:
> Do you need the BaseAlign parameter? It seems at all instances it could be computed inside the OpSplitter from the InsertionPoint and DL using getAdjustedAlignment().
It's not essential, but I think it makes sense to update the alignment as we go rather than recalculating exactly the same thing repeatedly for each load.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54743/new/

https://reviews.llvm.org/D54743