[PATCH] D54783: [Power9] suboptimal vec_abs for some cases

Fri Dec 14 01:07:23 PST 2018

jedilyn marked an inline comment as done.
jedilyn added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-P9-vabsd.ll:4
+; RUN: llc < %s -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr8 -ppc-vsr-nums-as-vr -ppc-asm-full-reg-names -verify-machineinstrs | FileCheck %s -check-prefix=CHECK-PWR8 -implicit-check-not vabsdu

 define <4 x i32> @simple_absv_32(<4 x i32> %a) local_unnamed_addr {
----------------
inouehrs wrote:
> It is nice to have a test case for pwr7, i.e. hasP8Altivec = false, to confirm that v2i64 is not optimized but others are optimized.
> 
Good point, thanks @inouehrs ! I'll add one case for it.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54783/new/

https://reviews.llvm.org/D54783