[PATCH] D55303: [RISCV] Add lowering of addressing sequences for PIC

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added a comment.

Minor comment above but other than that this looks good to me too.



================
Comment at: lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:616
+  if (!MF->getTarget().isPositionIndependent())
+    return expandAuipcInstPair(MBB, MBBI, NextMBBI, RISCVII::MO_PCREL_HI,
+                               RISCV::ADDI);
----------------
Perhaps it is clearer if we call `expandLoadLocalAddress` here instead of repeating the call to `expandAuipcInstPair`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55303/new/

https://reviews.llvm.org/D55303