[PATCH] D55666: [Transforms] Preserve access metadata.
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 13 20:12:51 PST 2018
hfinkel added inline comments.
================
Comment at: lib/Transforms/Utils/Local.cpp:1973
NewCall->setDebugLoc(II->getDebugLoc());
+ NewCall->copyMetadata(*II, LLVMContext::MD_mem_parallel_loop_access);
II->replaceAllUsesWith(NewCall);
----------------
Can you please generalize this? We should preserve much more than this. LLVMContext::MD_alias_scope and LLVMContext::MD_noalias should be preserved as well. I don't believe that any of our current metadata is invalidated by this (although only a limited number can appear on calls).
Thanks!
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55666/new/
https://reviews.llvm.org/D55666
More information about the llvm-commits
mailing list