[PATCH] D55116: [CMake] llvm_codesign workaround for Xcode double-signing errors

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 13 16:55:56 PST 2018


beanz added a comment.

Sorry for being behind on this, but I don't think this is the right solution to the problem.

I don't think we should ever pass `--force`. To avoid duplicate code signing when using the Xcode generator we should set the `XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY` target property so that Xcode actually knows what signing identity to use and can properly build the target.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55116/new/

https://reviews.llvm.org/D55116





More information about the llvm-commits mailing list