[PATCH] D55679: # Enter a commit message. #

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv added a comment.

Chrome OS developed a dependency (perf, not functional) on things in .text.hot coming before things in .text. Namely, they have code that maps the first N MB of Chrome's .text section to hugepages, under the assumption that the code near the beginning of the binary will be hotter than the code near the end of the binary.

Naturally, this says nothing about how general programs will perform with this change. I similarly expect this to be more or less a wash for many programs.

I don't frequent lld often, but my 2c are that emulating this in lld is trivial and doing so AFAICT loses us nothing. Hence, I don't see a compelling reason to avoid this change. Since a user's tripped over this to the tune of a few percent perf regression (?), I'm more in favor than not.

Like said, I don't poke lld very much, so I have no plans to be the one who stamps this :)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55679/new/

https://reviews.llvm.org/D55679