[PATCH] D55554: [HWASAN/rt] Implement support for memory intrinsics
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 13 15:21:31 PST 2018
eugenis added inline comments.
================
Comment at: lib/hwasan/hwasan.cc:532
+void *__hwasan_memset(void *block, int c, uptr size) {
+ CheckAddressSized<ErrorAction::Abort, AccessType::Store>(
+ reinterpret_cast<uptr>(block), size);
----------------
eugenis wrote:
> This way -fsanitize-recover does not apply to mem intrinsics. I think, for consistency, there needs to be a __hwasan_memset_noabort variant, used in instrumentation when !Recover.
please also address this comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55554/new/
https://reviews.llvm.org/D55554
More information about the llvm-commits
mailing list