[PATCH] D55555: [LLD][ELF][ARM] Add support for architecture v6m thunks

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The thunks look fine.



================
Comment at: ELF/Thunks.cpp:785
       return addThunkPreArmv7(Reloc, S);
-    else
-      // The Armv6-m architecture (Cortex-M0) does not have Arm instructions or
-      // support the MOVT MOVW instructions so it cannot use any of the Thunks
-      // currently implemented.
-      fatal("thunks not supported for architecture Armv6-m");
+    return addThunkV6M(Reloc, S);
   }
----------------
Sort of orthogonal to this patch, but maybe worth noting how we know we're targeting v6m here; it isn't obvious to anyone who isn't deeply familiar with the history of ARM architecture versions. (Or maybe it's worth adding an extra boolean to the config?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55555/new/

https://reviews.llvm.org/D55555