[PATCH] D50200: AMDGPU: Handle "uniform-work-group-size" attribute

Thu Dec 13 13:27:16 PST 2018

aakanksha555 added a comment.

In D50200#1329491 <https://reviews.llvm.org/D50200#1329491>, @hakzsam wrote:

> Hi,
>
> This patch breaks RADV (and probably RadeonSI as well). Here's a backtrace of the problem:
>
> $ gdb --args ./deqp-vk --deqp-case=dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_frag
>  GNU gdb (GDB) 8.2
>  Copyright (C) 2018 Free Software Foundation, Inc.
>  License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
>  This is free software: you are free to change and redistribute it.
>  There is NO WARRANTY, to the extent permitted by law.
>  Type "show copying" and "show warranty" for details.
>  This GDB was configured as "x86_64-pc-linux-gnu".
>  Type "show configuration" for configuration details.
>  For bug reporting instructions, please see:
>  http://www.gnu.org/software/gdb/bugs/.
>  Find the GDB manual and other documentation resources online at:
>
>   <http://www.gnu.org/software/gdb/documentation/>.
>   
>
> For help, type "help".
>  Type "apropos word" to search for commands related to "word"...
>  Reading symbols from ./deqp-vk...(no debugging symbols found)...done.
>  (gdb) r
>  Starting program: /home/hakzsam/programming/VK-GL-CTS/build/external/vulkancts/modules/vulkan/deqp-vk --deqp-case=dEQP-VK.spirv_assembly.instruction.graphics.selection_block_order.out_of_order_frag
>  [Thread debugging using libthread_db enabled]
>  Using host libthread_db library "/usr/lib/libthread_db.so.1".
>  Writing test log into TestResults.qpa
>  dEQP Core git-12aa347f43c85df3a0daf930739551d3f53d3d48 (0x12aa347f) starting..
>
>   target implementation = 'Default'
>
> [New Thread 0x7ffff1968700 (LWP 4723)]
>  [Thread 0x7ffff1968700 (LWP 4723) exited]
>  [New Thread 0x7ffff1968700 (LWP 4724)]
>
> Thread 1 "deqp-vk" received signal SIGSEGV, Segmentation fault.
>  0x00007ffff447a81a in llvm::ValueHandleBase::AddToExistingUseList (this=this at entry=0x7fffffffbc50, List=0x7ffff5fdab80 <vtable for llvm::AAResults::Model<llvm::ScopedNoAliasAAResult>+16>) at ../lib/IR/Value.cpp:745
>  745	  *List = this;
>  (gdb) bt
>  #0  0x00007ffff447a81a in llvm::ValueHandleBase::AddToExistingUseList (this=this at entry=0x7fffffffbc50, List=0x7ffff5fdab80 <vtable for llvm::AAResults::Model<llvm::ScopedNoAliasAAResult>+16>) at ../lib/IR/Value.cpp:745
>  #1  0x00007ffff572fd87 in llvm::ValueHandleBase::ValueHandleBase (RHS=..., Kind=llvm::ValueHandleBase::WeakTracking, this=0x7fffffffbc50) at ../include/llvm/ADT/PointerIntPair.h:150
>  #2  llvm::WeakTrackingVH::WeakTrackingVH (RHS=..., this=0x7fffffffbc50) at ../include/llvm/IR/ValueHandle.h:187
>  #3  std::pair<llvm::WeakTrackingVH, llvm::CallGraphNode*>::pair (this=0x7fffffffbc50) at /usr/include/c++/8.2.1/bits/stl_pair.h:303
>  #4  (anonymous namespace)::AMDGPUAnnotateKernelFeatures::processUniformWorkGroupAttribute (this=0x555557e87570) at ../lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:224
>  #5  (anonymous namespace)::AMDGPUAnnotateKernelFeatures::runOnSCC (this=<optimized out>, SCC=...) at ../lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:355
>  #6  0x00007ffff51d3d47 in (anonymous namespace)::CGPassManager::RunPassOnSCC (DevirtualizedCall=<synthetic pointer>: <optimized out>, CallGraphUpToDate=<synthetic pointer>: <optimized out>, CG=..., CurSCC=..., P=
>
>   0x555557e87570, this=0x555557e87650) at ../lib/Analysis/CallGraphSCCPass.cpp:141
>
> #7  (anonymous namespace)::CGPassManager::RunAllPassesOnSCC (DevirtualizedCall=<synthetic pointer>: <optimized out>, CG=..., CurSCC=..., this=0x555557e87650) at ../lib/Analysis/CallGraphSCCPass.cpp:442
>  #8  (anonymous namespace)::CGPassManager::runOnModule (this=0x555557e87650, M=...) at ../lib/Analysis/CallGraphSCCPass.cpp:498
>  #9  0x00007ffff4428fba in (anonymous namespace)::MPPassManager::runOnModule (M=..., this=0x555557e65c20) at ../lib/IR/LegacyPassManager.cpp:1744
>  #10 llvm::legacy::PassManagerImpl::run (this=0x555557e657b0, M=...) at ../lib/IR/LegacyPassManager.cpp:1857
>  #11 0x00007ffff61fa7a6 in ac_compile_module_to_binary (p=0x555557e65750, module=module at entry=0x555557eb65a0, binary=binary at entry=0x7fffffffc080) at /home/hakzsam/install/llvm/debug/master/include/llvm/IR/Module.h:889
>  #12 0x00007ffff61b6e2b in radv_llvm_per_thread_info::compile_to_memory_buffer (this=<optimized out>, binary=0x7fffffffc080, module=0x555557eb65a0) at radv_llvm_helper.cpp:97
>  #13 radv_compile_to_binary (info=info at entry=0x7fffffffc050, module=module at entry=0x7ffff61fa7a6 <ac_compile_module_to_binary(ac_compiler_passes*, LLVMModuleRef, ac_shader_binary*)+22>, binary=binary at entry=0x7fffffffc080)
>
>   at radv_llvm_helper.cpp:97
>
> #14 0x00007ffff61b0d81 in ac_llvm_compile (ac_llvm=0x7fffffffc050, binary=0x7fffffffc080, M=0x7ffff61fa7a6 <ac_compile_module_to_binary(ac_compiler_passes*, LLVMModuleRef, ac_shader_binary*)+22>) at radv_nir_to_llvm.c:3660
>  #15 ac_compile_llvm_module (ac_llvm=ac_llvm at entry=0x7fffffffc050, llvm_module=0x7ffff61fa7a6 <ac_compile_module_to_binary(ac_compiler_passes*, LLVMModuleRef, ac_shader_binary*)+22>, binary=binary at entry=0x7fffffffc080,
>
>   config=0x7fffffffc080, config at entry=0x555557f71778, stage=MESA_SHADER_COMPUTE, options=0x7fffffffc140, shader_info=<optimized out>, shader_info=<optimized out>) at radv_nir_to_llvm.c:3684
>
> #16 0x00007ffff61b65d0 in radv_compile_nir_shader (ac_llvm=ac_llvm at entry=0x7fffffffc050, binary=binary at entry=0x7fffffffc080, config=config at entry=0x555557f71778, shader_info=shader_info at entry=0x555557f717a0,
>
>   nir=nir at entry=0x7fffffffc388, nir_count=nir_count at entry=1, options=0x7fffffffc140) at radv_nir_to_llvm.c:3808
>
> #17 0x00007ffff61c56db in shader_variant_create (device=device at entry=0x555557e4d920, module=0x7fffffffcd40, shaders=shaders at entry=0x7fffffffc388, shader_count=shader_count at entry=1, stage=MESA_SHADER_COMPUTE,
>
>   options=options at entry=0x7fffffffc140, gs_copy_shader=false, code_out=0x7fffffffc3b8, code_size_out=0x7fffffffc2e4) at radv_shader.c:612
>
> #18 0x00007ffff61c5b04 in radv_shader_variant_create (device=device at entry=0x555557e4d920, module=<optimized out>, shaders=shaders at entry=0x7fffffffc388, shader_count=shader_count at entry=1, layout=<optimized out>,
>
>   key=key at entry=0x7fffffffc810, code_out=0x7fffffffc3b8, code_size_out=0x7fffffffc2e4) at radv_shader.c:666
>
> #19 0x00007ffff61b8aa6 in radv_create_shaders (pipeline=0x555557ef5ca0, device=<optimized out>, cache=0x555557e4d998, key=<optimized out>, pStages=<optimized out>, flags=<optimized out>) at radv_pipeline.c:2151
>  #20 0x00007ffff61bf7eb in radv_compute_pipeline_create (pPipeline=0x555557e4ef70, pAllocator=<optimized out>, pCreateInfo=0x7fffffffcbd0, _cache=<optimized out>, _device=0x555557e4d920) at radv_pipeline.c:3787
>  #21 radv_CreateComputePipelines (_device=_device at entry=0x555557e4d920, pipelineCache=pipelineCache at entry=0x555557e4d998, count=count at entry=1, pCreateInfos=pCreateInfos at entry=0x7fffffffcbd0, pAllocator=pAllocator at entry=0x0,
>
>   pPipelines=pPipelines at entry=0x555557e4ef70) at radv_pipeline.c:3817
>
> #22 0x00007ffff619653a in radv_device_init_meta_itob_state (device=0x555557e4d920) at radv_private.h:1986
>  #23 radv_device_init_meta_bufimage_state (device=device at entry=0x555557e4d920) at radv_meta_bufimage.c:1489
>  #24 0x00007ffff6175a4a in radv_device_init_meta (device=device at entry=0x555557e4d920) at radv_meta.c:365
>  #25 0x00007ffff61680d0 in radv_CreateDevice (physicalDevice=0x555557d7c0e0, pCreateInfo=0x7fffffffd0d0, pAllocator=<optimized out>, pDevice=0x555557d82ec0) at radv_device.c:1702
>  #26 0x00007ffff640c574 in ?? () from /usr/lib/libvulkan.so.1
>  #27 0x00007ffff641599b in ?? () from /usr/lib/libvulkan.so.1
>  #28 0x00007ffff6419b29 in vkCreateDevice () from /usr/lib/libvulkan.so.1
>  #29 0x0000555556942f7d in vk::createDevice(vk::PlatformInterface const&, vk::VkInstance_s*, vk::InstanceInterface const&, vk::VkPhysicalDevice_s*, vk::VkDeviceCreateInfo const*, vk::VkAllocationCallbacks const*) ()
>  #30 0x00005555558a3384 in vkt::DefaultDevice::DefaultDevice(vk::PlatformInterface const&, tcu::CommandLine const&) ()
>  #31 0x00005555558a40e5 in vkt::Context::Context(tcu::TestContext&, vk::PlatformInterface const&, vk::ProgramCollection<vk::ProgramBinary, vk::BinaryBuildOptions>&) ()
>  #32 0x000055555588c3e2 in vkt::TestCaseExecutor::TestCaseExecutor(tcu::TestContext&) ()
>  #33 0x000055555588c552 in vkt::TestPackage::createExecutor() const ()
>  #34 0x0000555556e04964 in tcu::TestSessionExecutor::iterate() ()
>  #35 0x0000555556dd89a9 in tcu::App::iterate() ()
>  #36 0x000055555587e4e8 in main ()
>
> Can you look into it?
>
> Thanks!

Sorry about that. I have reverted the changes until I fix this.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50200/new/

https://reviews.llvm.org/D50200