[PATCH] D55459: [DAGCombiner][X86] Prevent visitSIGN_EXTEND from returning N when (sext (setcc)) already has the target desired type for the setcc
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 13 13:17:02 PST 2018
spatel added inline comments.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:39145
+ // CombineTo was used which prevented the target combines from running.
+ // Earlying out here to avoid regressions.
+ // FIXME: Can we remove this?
----------------
Just in case we don't get vector widening legalization done soon, I think this comment should describe the potential regressions and/or what's broken/missing that would prevent that problem.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55459/new/
https://reviews.llvm.org/D55459
More information about the llvm-commits
mailing list