[PATCH] D54749: Saturating float to int casts: Basics [1/n]

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 13 02:42:33 PST 2018

Previous message: [PATCH] D54749: Saturating float to int casts: Basics [1/n]
Next message: [PATCH] D54749: Saturating float to int casts: Basics [1/n]
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

t.p.northover added a comment.

I think the consistency argument is good, so I'm in favour of the structure you chose now. My main issue at the moment is the tests: hard-coding register usage leads to very fragile tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749

Previous message: [PATCH] D54749: Saturating float to int casts: Basics [1/n]
Next message: [PATCH] D54749: Saturating float to int casts: Basics [1/n]
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list